Skip to content

Remove ammo from non-combat merchants#4613

Open
chief-turkler wants to merge 1 commit into
CombatExtended-Continued:Developmentfrom
chief-turkler:ammo-trader-changes
Open

Remove ammo from non-combat merchants#4613
chief-turkler wants to merge 1 commit into
CombatExtended-Continued:Developmentfrom
chief-turkler:ammo-trader-changes

Conversation

@chief-turkler

@chief-turkler chief-turkler commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Changes

Removed ammo stocks from most non-combat traders.
Also made some changes to availability of ammo in traders. Combat merchants are left unchanged, slavers get a small amount of small-caliber ammo because their occupation is basically aligned with violence and it'd make sense for them to sell some alongside other slavery gear.

Reasoning

  • It doesn't make sense for people dealing in metals and fresh produce to stock autocannon shells.
  • Combat Extended currently has a feature where if a weapon is found in a trader's inventory/in a quest reward/in a pod drop/etc. it will also have fitting ammo alongside it. If a merchant is selling a gun, it's already going to be selling ammo for that gun.
  • Dedicated combat merchants already exist and it makes them a bit pointless if most traders can stock most ammo.

Alternatives

Current system:

  • Breaks immersion.
  • Kinda ruins the point of having seperate combat traders if bulk goods traders are equally as capable of stocking mortar shells.

Testing

Check tests you have performed:

  • Compiles without warnings - Changes do not require a recompile
  • Game runs without errors
  • Playtested a colony (specify how long) - 10-20 minutes to make sure I haven't broken anything

@chief-turkler chief-turkler requested review from a team as code owners June 8, 2026 09:36
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-27128820749.zip

@github-actions github-actions Bot added the Download in Comments This PR has a zipfile download available. label Jun 8, 2026
@chief-turkler

Copy link
Copy Markdown
Contributor Author

This is probably a bit extra but trade tags for certain ammo types would be neat so that we can have slavers always stock non-lethal ammo like beanbags and whatnot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Download in Comments This PR has a zipfile download available.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant